Skip to content

Remove deprecated rcParams entries and functions. #8721

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 6, 2017

Conversation

anntzer
Copy link
Contributor

@anntzer anntzer commented Jun 5, 2017

All's in the title.

PR Summary

PR Checklist

  • Has Pytest style unit tests
  • Code is PEP 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/whats_new.rst if major new feature
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

tacaswell
tacaswell previously approved these changes Jun 5, 2017
@tacaswell tacaswell dismissed their stale review June 5, 2017 21:24

Noted additional change that is needed.

Copy link
Member

@tacaswell tacaswell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The related entries in matplotlib.__init__.py also need to be removed, but 👍 on this change.

@anntzer
Copy link
Contributor Author

anntzer commented Jun 5, 2017

Review addressed.

@anntzer anntzer force-pushed the remove-deprecated-functions branch from d683db1 to 6a10b56 Compare June 5, 2017 22:27
Removed internal functions
--------------------------

The ``matplotlib.backends.backend_ps.seq_allequal`` function has been removed.
Use ``np.array_equal`` instead.

The deprecated `matplotlib.rcsetup.validate_maskedarray`,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Err, actually, since these are now deleted, they should be code, not references.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good point... fixed

@anntzer anntzer force-pushed the remove-deprecated-functions branch from 6a10b56 to 2ee7401 Compare June 5, 2017 23:42
@tacaswell tacaswell added this to the 2.1 (next point release) milestone Jun 6, 2017
@tacaswell tacaswell merged commit 02477de into matplotlib:master Jun 6, 2017
@anntzer anntzer deleted the remove-deprecated-functions branch June 6, 2017 06:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants