-
-
Notifications
You must be signed in to change notification settings - Fork 7.9k
removing sgskip #8725
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
removing sgskip #8725
Conversation
looks like you need to remove the coding utf8 line (but that may be considered as a s-g bug too) (I guess you may want to see whether other files were sgskipped for the same reason) |
hmm - let's see if removing that line solves the problem and I can look into whether this is an issue elsewhere too |
The other files that could be affected are userdemo/pgf_*.py, but they probably need to be modified a little bit: they use a noninteractive backend, even though they do ultimately generate a png file so at least in theory s-g may be able to handle them... I guess a workaround is to indeed write their output, but then add a line that reads the png and displays it using an interactive backend. EDIT: they actually need the coding set (for py2) as they do contain unicode... but that line needs to be moved before the docstring |
how could I test this out on my computer? last night I tried building sphinx gallery w/ both python 2 and 3 on my machine and it worked OK, so it made things a bit hard to debug. Did you figure out how to make this error on your computer? |
test what? right now python2 examples/userdemo/pgf_fonts_sgskip.py just errors out, but works with py3 |
huh - it was working for me on python2 that's what was confusing me |
oops sorry, not pgf_fonts_skip, I was talking about |
ok I reproduced the error on my end too. So I have two questions about these examples:
|
|
@anntzer so it'd be fixed if s-g stripped the encoding line before trying to do anything? I can open an issue though it's unclear whether I've got my head wrapped around this problem totally...encoding w strings always confuses me |
I think so. |
fingers crossed that the tests magically pass...