Skip to content

Parameterize test_fill_between and test_fill_betweenx #8729

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 8, 2017
Merged

Parameterize test_fill_between and test_fill_betweenx #8729

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f76a010
Parameterize test_fill_between and test_fill_betweenx
patniharshit Jun 7, 2017
a0ccb78
Add ids to test_fill_between tests
patniharshit Jun 7, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Add ids to test_fill_between tests
  • Loading branch information
@patniharshit
patniharshit committed Jun 7, 2017
commit a0ccb78c269311b4dd4d3b70ee87d989dd2ba1cb
8 changes: 8 additions & 0 deletions lib/matplotlib/tests/test_axes.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -852,6 +852,10 @@ def test_polycollection_joinstyle():
(np.zeros((2, 2)), 3, 3),
(np.arange(0.0, 2, 0.02), np.zeros((2, 2)), 3),
(np.arange(0.0, 2, 0.02), 3, np.zeros((2, 2)))
], ids=[
'2d_x_input',
'2d_y1_input',
'2d_y2_input'
]
)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add some ids to this call; you can use the unique parts of the original functions names, probably.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for pointing that out. Added.

def test_fill_between_input(x, y1, y2):
Expand All @@ -866,6 +870,10 @@ def test_fill_between_input(x, y1, y2):
(np.zeros((2, 2)), 3, 3),
(np.arange(0.0, 2, 0.02), np.zeros((2, 2)), 3),
(np.arange(0.0, 2, 0.02), 3, np.zeros((2, 2)))
], ids=[
'2d_y_input',
'2d_x1_input',
'2d_x2_input'
]
)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And some ids here too.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added

def test_fill_betweenx_input(y, x1, x2):
Expand Down