Skip to content

Add test to colorbar.py to see if ax is an object as returned by plt.subplots #8733

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 26 commits into from
Closed

Add test to colorbar.py to see if ax is an object as returned by plt.subplots #8733

Changes from 1 commit
Commits
Show all changes
26 commits
Select commit Hold shift + click to select a range
67d2324
Make histogram example figures fit on web page
dstansby May 12, 2017
719d556
Clarify how a FancyArrowPatch behaves
dstansby Jun 2, 2017
5d88cca
Fix typos
taehoonlee Jun 3, 2017
22488ff
Various cleanups to backends code.
anntzer Jun 3, 2017
df9e1d7
removing sgskip
choldgraf Jun 7, 2017
bb29bb6
Clarify in display units
dstansby Jun 7, 2017
f76a010
Parameterize test_fill_between and test_fill_betweenx
patniharshit Jun 7, 2017
a0ccb78
Add ids to test_fill_between tests
patniharshit Jun 7, 2017
2e6b968
colorbar.py: added test to see if parents are an object and to flatte…
jklymak Jun 8, 2017
7146ae6
Fixed PEP 8 error
jklymak Jun 8, 2017
1774e56
Merge pull request #8709 from taehoonlee/fix_typos
QuLogic Jun 8, 2017
34fda3e
Merge pull request #8729 from patniharshit/test_fill_between
QuLogic Jun 8, 2017
7fd3e25
Fixed so that we check to see if the object is an ndarray
jklymak Jun 8, 2017
80e9ec1
simplified logic to take into account all possible input cases
jklymak Jun 9, 2017
622307f
Merge pull request #8614 from dstansby/hist-example
tacaswell Jun 9, 2017
95cfdeb
Merge pull request #8725 from choldgraf/rem_sgskip
tacaswell Jun 9, 2017
1383228
Merge pull request #8703 from dstansby/fancyarrowpatch-clarify
anntzer Jun 9, 2017
4d26d74
Allow divmod to be overridden by numpy
dstansby Jun 9, 2017
60f547a
Merge pull request #8735 from dstansby/fix-tests
dstansby Jun 9, 2017
90ded74
Merge pull request #8711 from anntzer/backends-cleanup
QuLogic Jun 9, 2017
a5053c3
colorbar.py: added test to see if parents are an object and to flatte…
jklymak Jun 8, 2017
e178d2b
Fixed PEP 8 error
jklymak Jun 8, 2017
c4ea69a
Fixed so that we check to see if the object is an ndarray
jklymak Jun 8, 2017
0e31a22
simplified logic to take into account all possible input cases
jklymak Jun 9, 2017
3b2e06f
Rebased, hopefully get rid of CI error
jklymak Jun 9, 2017
b82411a
Rebased, hopefully get rid of CI error
jklymak Jun 9, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fixed so that we check to see if the object is an ndarray
  • Loading branch information
@jklymak
jklymak committed Jun 9, 2017
commit c4ea69a84523303e19dfd1713c6d823f63d98719
2 changes: 1 addition & 1 deletion lib/matplotlib/colorbar.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1118,7 +1118,7 @@ def make_axes(parents, location=None, orientation=None, fraction=0.15,
pad = kw.pop('pad', loc_settings['pad'])

# turn parents into a list if it is not already
if isinstance(parents, object):
if isinstance(parents, np.ndarray):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would replace this and the lines below by

parents = np.atleast_1d(parents).ravel().tolist()

(there will never be enough axes for this to be a performance issue...)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, that seems to work. Very clever!

parents = parents.flatten().tolist()
if not isinstance(parents, (list, tuple)):
parents = [parents]
Expand Down