Skip to content

Made colorbar.py accept numpy array input, compatible with output fro… #8739

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 12, 2017
Merged

Made colorbar.py accept numpy array input, compatible with output fro… #8739

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4ace2a4
Colorbar now accepts ndarray of axes, not just list
jklymak Jun 10, 2017
585c670
Colorbar now accepts ndarray of axes, not just list
jklymak Jun 11, 2017
81271ff
Colorbar now accepts ndarray of axes, not just list
jklymak Jun 11, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Colorbar now accepts ndarray of axes, not just list
  • Loading branch information
@jklymak
jklymak committed Jun 10, 2017
commit 4ace2a41a1b5f3ca48dd24c7b8ca593239f82f5f
7 changes: 4 additions & 3 deletions lib/matplotlib/colorbar.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1117,9 +1117,10 @@ def make_axes(parents, location=None, orientation=None, fraction=0.15,
parent_anchor = kw.pop('panchor', loc_settings['panchor'])
pad = kw.pop('pad', loc_settings['pad'])

# turn parents into a list if it is not already
if not isinstance(parents, (list, tuple)):
parents = [parents]
# turn parents into a list if it is not already. We do this w/ np
# because `ax=plt.subplots(1,1)` is an ndarray and is natural to
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Picky thing, but this comment is not quite right, should should be fig, ax_arr = plt.subplots(squeeze=False) or something like that.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"We do this because plt.subplots can return axes in an ndarray and ..."

Copy link
Member Author

@jklymak jklymak Jun 11, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Picky is good. Thanks, now reads:

    # turn parents into a list if it is not already. We do this w/ np
    # because `plt.subplots` can return an ndarray and is natural to
    # pass to `colorbar`.
    parents = np.atleast_1d(parents).ravel()

# pass to `colorbar`.
parents = np.atleast_1d(parents).ravel().tolist()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually it looks like you can drop the tolist(), a flat array should be just fine.


fig = parents[0].get_figure()
if not all(fig is ax.get_figure() for ax in parents):
Expand Down