Simplify some examples. #8741
Merged
Simplify some examples. #8741
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dstansby
reviewed
Jun 12, 2017
| plt.axis([-3, 3, -3, 3]) | ||
| plt.plot([0, 4], [0, 4]) | ||
| plt.title('still equal after adding line', fontsize=10) | ||
| plt.gca().set_aspect('equal', 'box') |
There was a problem hiding this comment.
Could also do with a plt.subplots() and removing all the plt.subplot calls?
dstansby
approved these changes
Jun 12, 2017
story645
reviewed
Jun 12, 2017
|
|
||
| vax.plot(t, s + nse, '^') | ||
| vax.vlines(t, [0], s) | ||
| vax.vlines([1, 2], 0, 1, transform=btf(vax.transData, vax.transAxes), colors='r') | ||
| vax.vlines([1, 2], 0, 1, transform=vax.get_xaxis_transform(), colors='r') |
There was a problem hiding this comment.
I feel like vax.get_xaxis_transform() would benefit from an explanatory comment of why it's in this code.
There was a problem hiding this comment.
you get to write it then :)
There was a problem hiding this comment.
I have no idea why it's there, hence why I'd like to see that comment.
| """ | ||
|
|
||
|
|
||
| import matplotlib.pyplot as plt | ||
| import numpy as np | ||
|
|
||
| # Plot circle or radius 3 |
`vline_hline_demo`: Simpler data generation; use `subplots`; no need to explicitly construct a blended transform. `equal_aspect_ratio`: Removed; forcing equal aspect ratio when the x and y axes have different units is pretty silly anyways, plus it does not belong in `subplots_axes_and_figures`. Instead, tweaked the last example of `axis_equal_demo` to demonstrate some more related features.
dstansby
approved these changes
Jun 13, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
vline_hline_demo: Simpler data generation; usesubplots; no need toexplicitly construct a blended transform.
equal_aspect_ratio: Removed; forcing equal aspect ratio when the x andy axes have different units is pretty silly anyways, plus it does not
belong in
subplots_axes_and_figures. Instead, tweaked the lastexample of
axis_equal_demoto demonstrate some more related features.PR Summary
PR Checklist