Skip to content

Faster path drawing for the cairo backend (cairocffi only) #8787

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
May 6, 2018
Merged

Faster path drawing for the cairo backend (cairocffi only) #8787

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
3edc982
cairo: Don't copy the ravelled image.
anntzer Jun 22, 2017
b549d12
cairo: save a pair of ctx.save/ctx.restore.
anntzer Jun 22, 2017
8a07eef
Faster path drawing with cairocffi.
anntzer Jun 21, 2017
52ed746
Implement draw_path_collection for cairo.
anntzer Jun 21, 2017
5312461
Document a bit the cairo fast path.
anntzer Jun 22, 2017
1a2848d
Actually support quadratic Beziers.
anntzer Jun 23, 2017
aca804f
Address review comments.
anntzer Feb 3, 2018
7a727a1
Avoid triggering a DeprecationWarning.
anntzer Feb 6, 2018
abbcb3e
Rebase for mpl3.
anntzer May 6, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Avoid triggering a DeprecationWarning.
  • Loading branch information
@anntzer
anntzer committed May 6, 2018
commit 7a727a1eda7076daa01dcdcbed77ed0c519d986b
2 changes: 2 additions & 0 deletions lib/matplotlib/backends/backend_cairo.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -307,6 +307,8 @@ def _draw_paths():
# We actually need to call the setters to reset the internal state.
vars(gc).update(gc_vars)
for k, v in gc_vars.items():
if k == "_linestyle": # Deprecated, no effect.
continue
try:
getattr(gc, "set" + k)(v)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No underscore is needed?

Copy link
Contributor Author

@anntzer anntzer Feb 3, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually no, I'm just copying the __dict__ of the original gc, and (kind of an implementation detail...) GraphicsContextBase stores "property" foo (accessed by get/set_foo) in ._foo). Not very elegant I admit.

except (AttributeError, TypeError) as e:
Expand Down