Remove redundant variables in pcolormesh. #8801
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anntzer
approved these changes
Jun 26, 2017
|
Nice cleanup, thank you. |
QuLogic
added a commit
to QuLogic/cartopy
that referenced
this pull request
Jun 27, 2017
efiring
added a commit
to efiring/matplotlib
that referenced
this pull request
Jun 27, 2017
Closes matplotlib#8534 (divide-by-zero warning). Also fixes a bug that became evident with matplotlib#8801, which causes pcolormesh to fail if X or Y is a masked array. Although masked arrays are not supported by pcolormesh, previously it would ignore the mask. Locators always return masked arrays, so the present commit explicitly converts to an ndarray the Locator output used by proportional colorbars.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was going through
pcolormeshin Cartopy to optimize it a bit, and I noticed these extra copies of variables, which I cleaned up and want to keep in sync, hence this PR. I don't believe the first bit saves much as they're probably views in latest NumPy, but dropping the extraptsshould save a little bit of memory.