Skip to content

Mask invalid values by default when setting log scale #8836

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jul 15, 2017

Conversation

dstansby
Copy link
Member

@dstansby dstansby commented Jul 3, 2017

This supersedes #8056 and #8537. See especially #8537 for previous discussion.

This should fix a few bugs: #8045, #8783

@dstansby dstansby added this to the 2.1 (next point release) milestone Jul 3, 2017
@tacaswell
Copy link
Member

On the bright side our test suite catches the API change!

@dstansby
Copy link
Member Author

dstansby commented Jul 4, 2017

I'm completely baffled by the travis failure on the .svg figure. I can't reproduce it on OSX or Linux (Python 3.6.1, Inkscape 0.92.1). Might it be because travis is using version inkscape_0.48.4-3ubuntu2?

@dstansby
Copy link
Member Author

dstansby commented Jul 4, 2017

Close, but no cigar. Force installing the latest stable build of Inkscape gives an error of 0.001 vs. 0.044 for the default version. Perhaps this is going to need a custom tolerance on the image comparison?

https://travis-ci.org/dstansby/matplotlib/jobs/250114851#L3193 is a branch with latest stable Inkscape

@tacaswell
Copy link
Member

Can you re-generate the svg and add it to the patch. A while ago we changed how the number is the SVG output were encoded which resulted in similar inkscape version dependent failures.

A feature of the vector outputs is that different text can result in the same image (which is why we test on comparing the rasterizations not the text), but it can lead to small issues like this.

@dstansby
Copy link
Member Author

dstansby commented Jul 6, 2017

🎊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants