Pylab example moves 2 #8857
Merged
Pylab example moves 2 #8857
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tacaswell
reviewed
Jul 10, 2017
| @@ -9,11 +9,11 @@ | |||
| import matplotlib.pyplot as plt | |||
|
|
|||
|
|
|||
| data = [[ 66386, 174296, 75131, 577908, 32015], | |||
There was a problem hiding this comment.
🚲 🏚️ minor preference for leaving this formatting the way it is for human readability.
tacaswell
reviewed
Jul 10, 2017
| @@ -4,7 +4,8 @@ | |||
| ========= | |||
|
|
|||
| Make a pie charts of varying size - see | |||
| http://matplotlib.org/api/pyplot_api.html#matplotlib.pyplot.pie for the docstring. | |||
| http://matplotlib.org/api/pyplot_api.html#matplotlib.pyplot.pie for the | |||
tacaswell
reviewed
Jul 10, 2017
| """ | ||
| import matplotlib.pyplot as plt | ||
| import numpy as np | ||
|
|
||
| data = ((3, 1000), (10, 3), (100, 30), (500, 800), (50, 1)) | ||
|
|
||
| plt.xlabel("FOO") |
There was a problem hiding this comment.
Can we just change these to not 'FOO'? It is good practice to always label your axes 😈
|
Comments fixed. Can always squash everything to a couple of commits before this is merged. |
tacaswell
approved these changes
Jul 10, 2017
|
I am indifferent if this gets squashed or not. |
NelleV
reviewed
Jul 15, 2017
examples/scales/log_demo.py
Outdated
| plt.title('semilogy') | ||
| plt.grid(True) | ||
|
|
||
| # log x axis | ||
| plt.subplot(222) | ||
| plt.semilogx(t, np.sin(2*np.pi*t)) | ||
| plt.semilogx(t, np.sin(2 * np.pi * t)) |
There was a problem hiding this comment.
FYI, the old formatting was fine in terms of pep8ness.
|
Also needs a rebase, sorry. |
|
Should also be rebased, fingers crossed for the doc build! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some more pylab example moves. Trying to keep these in relatively small PRs for easy review.