Skip to content

Fix eventplot colors kwarg #8861

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jul 11, 2017
Merged

Fix eventplot colors kwarg #8861

merged 4 commits into from
Jul 11, 2017

Conversation

tacaswell
Copy link
Member

Rebase of #8204

PR Summary

PR Checklist

  • Has Pytest style unit tests
  • Code is PEP 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/whats_new.rst if major new feature
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@tacaswell tacaswell added this to the 2.1 (next point release) milestone Jul 11, 2017
@tacaswell tacaswell mentioned this pull request Jul 11, 2017
Closed
@tacaswell
Copy link
Member Author

Merging this as it passes, previously had an approve from @QuLogic , a request changes from me (which is addressed but I never cleared) and a request changes from @anntzer about the content of a re-formatted docstring which I am going to label as out-side of the scope of this PR.

@tacaswell tacaswell merged commit 4ec14fb into matplotlib:master Jul 11, 2017
@tacaswell tacaswell deleted the fix_eventplot_colors_kwarg branch July 11, 2017 14:33
@anntzer anntzer mentioned this pull request Oct 16, 2017
Closed
@anntzer anntzer mentioned this pull request Jan 11, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v2.1
Development

Successfully merging this pull request may close these issues.
2 participants
@tacaswell @afvincent