Update pylab example to OO format #8886
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@NelleV could you give a quick review? |
NelleV
approved these changes
Jul 15, 2017
examples/pylab_examples/log_test.py
Outdated
|
|
||
| plt.show() | ||
|
|
There was a problem hiding this comment.
I haven't looked at the travis log, but I wouldn't be surprised this blank line is a PEP8 violation.
There was a problem hiding this comment.
I thought that it was the oppose - that blank lines at the end of a file are required?
There was a problem hiding this comment.
since there needs to be a newline at the end?
There was a problem hiding this comment.
looking at travis I think you're right.
|
@dmgt Thanks and congratulation on (what I think is) your first Matplotlib PR 🎉 |
|
wooo!!! way to go!! 🎉 🎉 🎉 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Updating this example to use object oriented format as opposed to previous pyplot API.
PR Checklist