Skip to content

Fix stopping of Tk timers from with timer callback. #8937

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 25, 2017
Merged

Fix stopping of Tk timers from with timer callback. #8937

merged 1 commit into from
Jul 25, 2017

Conversation

anntzer
Copy link
Contributor

@anntzer anntzer commented Jul 25, 2017

Fixes #5163.

(Also don't stop the timer if callbacks is empty, as someone could add more callbacks to the list later.)

dopplershift
dopplershift approved these changes Jul 25, 2017
View reviewed changes
Copy link
Contributor

@dopplershift dopplershift left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. The behavior about not looking at callbacks does seem more consistent with other backends.

@tacaswell tacaswell merged commit 209abd8 into matplotlib:master Jul 25, 2017
@tacaswell tacaswell added this to the 2.1 (next point release) milestone Jul 25, 2017
@anntzer anntzer deleted the tktimer branch July 25, 2017 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dopplershift dopplershift dopplershift approved these changes

Assignees
No one assigned
Labels
GUI: tk
Projects
None yet
Milestone
v2.1
Development

Successfully merging this pull request may close these issues.
3 participants
@anntzer @dopplershift @tacaswell