let Qt4 backend ignore extra mouse buttons (fixes exceptions) #894
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| button = self.buttond.get(event.button()) | ||
| if button is not None: # only three buttons supported by MouseEvent | ||
| FigureCanvasBase.button_press_event( self, x, y, button ) | ||
| if DEBUG: print('button pressed:', event.button()) |
There was a problem hiding this comment.
Just to double check, is the print statement going to break older python versions in the 1.1.x branch?
There was a problem hiding this comment.
Why should it? Python 2.x will see a statement that outputs a tuple. (Sorry for the noise, the change came from master by accident.)
|
Thanks for the rebase. This looks good to go, and works for me. |
|
+1 |
mdboom
added a commit
that referenced
this pull request
May 24, 2012
let Qt4 backend ignore extra mouse buttons (fixes exceptions)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My mouse has more than three buttons, so I noticed by accident that the current qt4 backend does not cope with mouse events on the canvas for these buttons (but throws exceptions). Apart from fixing the exception, I introduced the use of Qt constants for readability, and added the two missing constants for the extra buttons in case someone wants to pick this up later and introduce support for these buttons.
This was discussed in pull request #890 and now rebased onto the v1.1.x branch as requested. (Note that during the rebase, the fix of the double-click handler got removed, because that one’s not present in 1.1.x yet.)