FIX: properly mix blitting + redraw in Qt4Agg/Qt5Agg #8948
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a draw is requested on the next paint event update the whole canvas, not just the blit boxes. Any un-shown blitted updates from before the full redraw are lost (due to the full update) and any blitted updates from after the full render (but before the paint event) will be included (because the renderer updates in-place). Closes matplotlib#7366
ae281e2 to
243d50d
Compare
6 tasks
|
See #8951 for an alternate approach and comments regarding performance. |
|
Closing in favor of #8951 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a draw is requested on the next paint event update the whole
canvas, not just the blit boxes. Any un-show blitted updates from
before the full redraw are lost (due to the full update) and any
blitted updates from after the full render (but before the paint
event) will be included (because the renderer updates in-place).
Closes #7366
It would be interesting to benchmark of blitting only sub-sections of the canvas actually helps performance.