Skip to content

Various documentation updates #8955

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jul 30, 2017
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -108,6 +108,9 @@ jobs:
name: "Built documentation is available at:"
command: echo "${CIRCLE_BUILD_URL}/artifacts/${CIRCLE_NODE_INDEX}/${CIRCLE_WORKING_DIRECTORY/#\~/$HOME}/doc/build/html/index.html"

- add_ssh_keys:
fingerprints:
- "78:13:59:08:61:a9:e5:09:af:df:3a:d8:89:c2:84:c0"
- deploy:
name: "Deploy new docs"
command: ./.circleci/deploy-docs.sh
Expand Down
4 changes: 2 additions & 2 deletions .circleci/deploy-docs.sh
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,8 @@

set -e

if [ "$CIRCLE_BRANCH" != "master" -o "$CIRCLE_PULL_REQUEST" != "" ]; then
echo "Not uploading docs from non-master branch."
if [ "$CIRCLE_PROJECT_USERNAME" != "matplotlib" -o "$CIRCLE_BRANCH" != "master" -o "$CIRCLE_PULL_REQUEST" != "" ]; then
echo "Not uploading docs from non-master branch or non-Matplotlib org."
exit
fi

Expand Down
2 changes: 1 addition & 1 deletion .github/PULL_REQUEST_TEMPLATE.md
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ detail. Why is this change required? What problem does it solve?-->
- [ ] Code is PEP 8 compliant
- [ ] New features are documented, with examples if plot related
- [ ] Documentation is sphinx and numpydoc compliant
- [ ] Added an entry to doc/users/whats_new.rst if major new feature
- [ ] Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
- [ ] Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

<!--We understand that PRs can sometimes be overwhelming, especially as the
Expand Down
8 changes: 5 additions & 3 deletions doc/conf.py
Original file line number Diff line number Diff line change
Expand Up @@ -102,9 +102,11 @@ def _check_deps():
'filename_pattern': '^((?!sgskip).)*$',
'gallery_dirs': ['gallery', 'tutorials'],
'doc_module': ('matplotlib', 'mpl_toolkits'),
'reference_url': {'matplotlib': None,
'numpy': 'http://docs.scipy.org/doc/numpy/reference',
'scipy': 'http://docs.scipy.org/doc/scipy/reference'},
'reference_url': {
'matplotlib': None,
'numpy': 'https://docs.scipy.org/doc/numpy',
'scipy': 'https://docs.scipy.org/doc/scipy/reference',
},
'backreferences_dir': 'api/_as_gen'
}

Expand Down
5 changes: 4 additions & 1 deletion doc/devel/release_guide.rst
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,10 @@ Review and commit changes. Some issue/PR titles may not be valid rst (the most
Check Docs
----------

Before tagging, make sure that the docs build cleanly ::
Before tagging, update the what's new listing in :file:`doc/users/whats_new.rst`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think it should be done in this PR, but I still think it'd be good to have some kind of "credit" system for various features. E.g. just making sure that every new feature or bugfix has a by XXX at the end, optionally with a link to a user webpage or something.

by merging all files in :file:`doc/users/next_whats_new/` coherently. Also,
temporarily comment out the include and toctree glob; re-instate these after a
release. Finally, make sure that the docs build cleanly ::

pushd doc
python make.py html latex -n 16
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,7 @@
This folder is for placing new portions of `whats_new.rst`.
What's new in unreleased Matplotlib?
====================================

Please place new portions of `whats_new.rst` in the `next_whats_new` directory.

When adding an entry please look at the currently existing files to
see if you can extend any of them. If you create a file, name it
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,11 +6,9 @@ A legend entry can now contain more than one legend key. The extended
legend area in the specified number of sections; ``pad`` changes the padding
between the legend keys.

.. figure:: ../../gallery/pylab_examples/images/sphx_glr_legend_demo6_001.png
:target: ../../gallery/pylab_examples/legend_demo6.html
.. figure:: /gallery/text_labels_and_annotations/images/sphx_glr_legend_demo_004.png
:target: ../../gallery/text_labels_and_annotations/legend_demo.html
:align: center
:scale: 50

Legend Demo6


Multiple Legend Keys
10 changes: 10 additions & 0 deletions doc/users/whats_new.rst
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,16 @@ revision, see the :ref:`github-stats`.
:depth: 3


..
For a release, add a new section after this, then comment out the include
and toctree below by indenting them. Uncomment them after the release.
.. include:: next_whats_new/README.rst
.. toctree::
:glob:
:maxdepth: 1

next_whats_new/*


New in matplotlib 2.0
=====================
Expand Down