-
-
Notifications
You must be signed in to change notification settings - Fork 7.9k
adding gallery sorting #8975
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adding gallery sorting #8975
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like you might have missed renaming a few cross-references.
Can you also update the dependencies to require sphinx-gallery>=0.1.12, because otherwise the backreferences fail?
doc/conf.py
Outdated
'../tutorials/introductory', | ||
'../tutorials/intermediate', | ||
'../tutorials/advanced'] | ||
for folder in glob('../examples/*') + glob('../tutorials/*'): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
glob
is not sorted.
ok I think I got all the cross references this time :-) |
doc/conf.py
Outdated
explicit_order_folders = ['../examples/pyplots', | ||
'../examples/statistics', | ||
'../examples/color', | ||
'../examples/pylab_examples', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this just got removed with #8983 (might have to rebase to see it, though.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
whoah way to go @NelleV ! I didn't know we were so close to moving everything outta that folder. I'll rebase and see if it's gone now.
doc/conf.py
Outdated
'../examples/statistics', | ||
'../examples/color', | ||
'../examples/pylab_examples', | ||
'../examples/showcase', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Showcase should maybe be higher?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 for that...any others you'd like to see reordered?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually - I just realized that a better solution here might be to use the viewing data from google analytics to choose the ordering. That might be a kind of self-reinforcing kind of thing, but it's a good first start
doc/conf.py
Outdated
'../examples/color', | ||
'../examples/pylab_examples', | ||
'../examples/showcase', | ||
'../tutorials/introductory', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Where should I be looking to find this? In the gallery page, I don't think I see any tutorials after showcase?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The way SG handles this is there's just one list that defines the order priority. So folders inside of tutorials and examples won't be shown together or anything, this just defines the ordering. You can think of this as two separate lists, one for examples and one for tutorials.
Happy dance that there's now ordering, but I do wonder if there's some natural clustering of the categories aside from metrics. The list is:
I expect that some of these are probably are already being collapsed into each other, but I think some limit like n=10 or whatever a usability expert would suggest on categories (there are almost 30 in the list) could help make it all seem less overwhelming? |
So I am definitely +1 on refactoring the examples (I actually think they should fall into a few sub-categories, since many of those examples aren't going to be of interest to non-dev users). But - that'll be complicated and will do things like breaking hard-links, so I'd prefer if we kept this PR focused on picking and implementing an order. WDYT? |
I totally agree it's out scope for this PR, it just seems like the sort of thing someone is already working on concurrently and so figured I'd throw it out there. As a first pass on ordering, I'm thinking roughly the following clusters:
|
That first group just seems like a weird mishmash. I mean, what are
"Specialty Plots" that aren't "Favorite Recipes". And why wouldn't our
favorites be "Showcased"?
And Statistics stands out like a sore thumb in that group. This is more an
argument to possibly rename those sections and/or consolidate them further.
…On Thu, Aug 3, 2017 at 11:49 AM, hannah ***@***.***> wrote:
I totally agree it's out scope for this PR, it just seems like the sort of
thing someone is already working on concurrently and so figured I'd throw
it out there.
As a first pass on ordering, I'm thinking roughly the following clusters:
Pyplot Examples (while this is most searched for, I debate promoting it to
top since this isn't the recommended style)
Statistics
Pylab Examples
Front Page
Showcase
Miscellaneous Examples
Our Favorite Recipes
Specialty Plots
Matplotlib API (though should maybe be moved right under/above pyplot
examples)
Animation Examples
Axes Grid
Axis Artist
Color
Images, contours and fields
Lines, bars and markers
Pie and polar charts
Shapes and collections
Scales in Matplotlib
Subplots, axes and figures
Style sheets
Text, labels and annotations
Ticks and spines
Units in Matplotlib
mplot3d toolkit
Event Handling
Embedding matplotlib in graphical user interfaces
Widgets
Userdemo
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#8975 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AARy-Ix2uuvqycWGvjG_4iRl_J0p1NMXks5sUewFgaJpZM4OqI9a>
.
|
Totally a mishmash. I just grabbed all the categories that just seem to be about displaying cool plots rather than showing off specific parts of the API 'cause they didn't seem to fit in anywhere else. I totally think they should be renamed and consolidated further. |
Just to re-iterate, this PR isn't about renaming or combining example folders...just agreeing on an initial ordering, though I think it's a good idea to open a subsequent PR about combining etc. I think if that's a direction people are friendly to, it should happen before 2.1 is released, because this will break a lot of links. to @story645's ordering, I think this is a good start! Agree we should shuffle things around a little bit. @WeatherGod do you have specific changes to the order that make more sense to you? |
@choldgraf pylab_examples is no more in the |
6cae847
to
744e074
Compare
ok latest push no longer has pylab examples! |
I would put Statistics and Miscellaneous as the last two in the first group.
…On Thu, Aug 3, 2017 at 9:09 PM, Chris Holdgraf ***@***.***> wrote:
ok latest push no longer has pylab examples!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#8975 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AARy-JpP5BlUlylvVjfGfXu5ozAaKbPIks5sUm9OgaJpZM4OqI9a>
.
|
👍 to getting the sorting in at all and defer bikeshedding of names, organization, etc to later work. |
744e074
to
3de5bad
Compare
3de5bad
to
0cb00ea
Compare
Now that sphinx-gallery allows you to choose folder ordering within galleries, this is a PR that attempts to give this a shot. I figured it'd be cumbersome to choose a custom ordering for all of our folders, since really we just wanna make sure that a subset are at the top. So, this PR defines that subset, and then lists all the subsequent folders alphabetically.
This PR does:
01_introductory
->introductory
since we don't need alphanumeric ordering anymoreLet's see how it looks in circle!