-
-
Notifications
You must be signed in to change notification settings - Fork 7.9k
Update for building matplotlib under Mac OS X 10.7 Lion and XCode > 4.2 #899
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Maybe we need to have more than one make.osx; I imagine quite a few people will still be building on older systems, so I don't think we want the older version of make.osx simply vanish. But we certainly do want to have a version that works on the latest. |
@@ -25,17 +25,17 @@ ZLIBURL=http://sourceforge.net/projects/libpng/files/zlib/${ZLIBVERSION}/${ZLIBF | |||
|
|||
PNGFILE=libpng-${PNGVERSION}.tar.gz | |||
PNGDIR=$(basename $(basename ${PNGFILE})) | |||
PNGURL=http://sourceforge.net/projects/libpng/files/libpng15/older-releases/${PNGVERSION}/${PNGFILE}/download | |||
PNGURL=http://sourceforge.net/projects/libpng/files/libpng15/${PNGVERSION}/${PNGFILE}/download |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As far as I can see, this has made the code more likely to fail. Currently PNGVERSION in this file is 1.5.4 but the 1.5.4 folder only exists in the older-releases folder
@XIRON: Did you try using the |
I got building to work with homebrew on 10.6 without using make.osx at all, so we might not really need make.osx for user builds. I think it has been used to build the downloadable binaries to work on a wide variety of OS X versions, and that use is probably still valid. |
What is the status of this PR? Do we need more testers? I have access to a user with this combination of specs who could do a test if needed. |
I don't have confidence that this change works (see my inline code comment), and @jkseppan and myself are awaiting to hear if using If there were a pause/hold button on pull requests, I would have it pressed for this PR. @XIRON: Does |
as an additional datapoint, the user I was referring to just yesterday built and installed matplotlib from the master branch just fine. I am pretty sure he is using homebrew as well. |
@XIRON: I'm closing this issue as I don't believe that the code can work anymore (the png library on the sourceforge site is no longer in that location). Additionally, it is currently best to build mpl via the standard We can always re-open this issue if there are good reasons to do so. If you are unable to build for osx 10.7 feel free to get in touch via the users or devel mailing list and I would be happy to help. |
No description provided.