FIX: logscale + subplots share axes #9000
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use `set_tick_params` to hide tick labels in not-edge plots instead of setting the visibility on the tick label objects. This catches both major and minor tick-labels and is more robust to changes in the ticklabel generation. closes matplotlib#8903
7c4eaea to
8fd417e
Compare
|
In which I learn that I did not have flake8 installed in the current venv.... |
|
I think this change might be part of #8678, though of course not with this intention. |
|
Ah, I thought #8678 was already merged :( That needs a rebase anyway, can you fold this commit into that PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
set_tick_paramsto hide tick labels in not-edge plots insteadof setting the visibility on the tick label objects.
This catches both major and minor tick-labels and is more robust to
changes in the ticklabel generation.
closes #8903
PR Summary
PR Checklist