Fix two cases of signed integer overflow. #9073
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This tweaks two cases where there is potential for signed integer overflow: * in `rewind_scanlines`, we switch to unsigned ints * in `not_equal`, we switch for operations which cannot overflow. These cases were caught by matplotlib-using tests being run under [ASan](https://github.com/google/sanitizers) with a check for signed integer overflow.
|
/cc @shoyer |
tacaswell
approved these changes
Aug 24, 2017
dopplershift
approved these changes
Aug 24, 2017
|
Travis passed but for some reason is reporting pending here. Merging... |
|
At some point we need to make a big diff of everything we have patched on agg and push it to upstream.... |
|
@craigcitro Thanks! Can I ask why you decided do this? |
|
@tacaswell we use matplotlib internally at Google. Someone had some matplotlib-using tests that they wanted to pass with extra checks in place, so rather than just maintain their patch internally, I thought I'd upstream it. 😉 |
|
@tacaswell I have this list, though probably need to update it quite a bit. |
|
I think we can generate it via git pick-axe? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
This tweaks two cases where there is potential for signed integer overflow:
rewind_scanlines, we switch to unsigned intsnot_equal, we switch for operations which cannot overflow.These cases were caught by matplotlib-using tests being run under
ASan with a check for signed integer
overflow.
PR Checklist
I did not see an easy way to add a test for this; I am happy to do so if someone has thoughts on a good place to include a test. (The "right" test to add would be a variant of the test suite running under ASan, but that seems a bit heavy for a small PR.)