Skip to content

use Qt window title as default savefig filename #908

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Jul 9, 2012
Merged

use Qt window title as default savefig filename #908

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
3983e93
use Qt window title as default savefig filename
mspacek May 29, 2012
16dd729
convert QString to string, and fix string.replace() oops
mspacek May 30, 2012
395acc1
in qt4 backend, define get_window_title and call it for default savef…
mspacek May 30, 2012
88dbef7
raise NotImplementedError instead of pass for FigureManagerBase windo…
mspacek May 30, 2012
41aa505
Supported & tested on wx, gtk, gtk3, qt3, tk.
May 31, 2012
f60f942
removed lower() on the filename
May 31, 2012
c090a9c
fix qt4 not using get_default_filename in save_figure
mspacek Jun 1, 2012
3b19a15
maintain compatibility with unimplemented backends
mspacek Jun 4, 2012
23deb00
Add window title management to MacOSX backend
jkseppan Jun 9, 2012
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
removed lower() on the filename
  • Loading branch information
@mspacek
Phil Elson authored and mspacek committed Jul 5, 2012
commit f60f942598f149f0673d440d63a2ca8b3fae69bb
2 changes: 1 addition & 1 deletion lib/matplotlib/backend_bases.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2114,7 +2114,7 @@ def get_default_filename(self):
a default filename.
"""
default_filename = self.get_window_title() or 'image'
default_filename = default_filename.lower().replace(' ', '_')
default_filename = default_filename.replace(' ', '_')
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As you probably guessed, I would prefer the filename to be lower case for the same reason that the spaces have been removed. Having said that, I'm not overly fussed if you would prefer to keep mixed case.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I agree with the lowercase thing. It's more of a gut feeling though -- and part of me feels like it should be lower case on Unix and mixed case on Windows, but that's probably a bad idea ;)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess I disagree with going lowercase because it's a loss of information, but I'm outnumbered, so I'll change it back :)

return default_filename + '.' + self.get_default_filetype()

def switch_backends(self, FigureCanvasClass):
Expand Down