BLD: bump minimum dateutil to 2.0 #9099
Merged
+3
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
efiring
approved these changes
Aug 27, 2017
|
appveyor failure is due to a connection failure to conda. |
WeatherGod
approved these changes
Aug 28, 2017
WeatherGod
reviewed
Aug 28, 2017
INSTALL.rst
Outdated
| @@ -178,7 +178,7 @@ Matplotlib requires a large number of dependencies: | |||
| * `Python <https://www.python.org/downloads/>`_ (>= 2.7 or >= 3.4) | |||
| * `NumPy <http://www.numpy.org>`_ (>= |minimum_numpy_version|) | |||
| * `setuptools <https://setuptools.readthedocs.io/en/latest/>`__ | |||
| * dateutil (>= 1.1) | |||
| * `dateutil <https://pypi.python.org/pypi/python-dateutil>`_) (>= 2.0) | |||
There was a problem hiding this comment.
ah, actually, just noticed a typo. A spurious closing paren?
- we had it documented as >= 1.1
- were not checking in setup.py
- the minimum version available on pypi is 1.5
- 2.0 is the first version that support python3
- 2.0 is > 5 years old
- debian versions
- wheezy (oldoldstable) has 1.5
- jessie (oldstable) has 2.2
2a4661d to
38137a6
Compare
|
@WeatherGod fixed and force-pushed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggested by @pganssle
He suggested just documenting >=2, but leaving setup.py unpinned. Opted to be a bit stronger about it so we can have the same minimum version on both python2 and python3