Skip to content

DOC: note that ipympl is external dependency #9126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 31, 2017

Conversation

tacaswell
Copy link
Member

attn @QuLogic

@tacaswell tacaswell added this to the 2.1 (next point release) milestone Aug 30, 2017
@tacaswell tacaswell mentioned this pull request Aug 31, 2017
Copy link
Member

@QuLogic QuLogic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor things...

# ipympl
# ------
#
# The jupyter widget ecosystem is moving too fast to support directly in
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Jupyter

@@ -414,7 +414,8 @@ def my_plotter(ax, data1, data2, param_dict):
# ============ ================================================================
# Qt5Agg Agg rendering in a :term:`Qt5` canvas (requires PyQt5_). This
# backend can be activated in IPython with ``%matplotlib qt5``.
# ipympl Agg rendering embedded in a Jupyter widget. This can be enabled
# ipympl Agg rendering embedded in a Jupyter widget. (requires ipympl)
# This can be enabled
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The break here was a bit confusing on first read.

@tacaswell
Copy link
Member Author

Both issues fixed and force-pushed.

@WeatherGod WeatherGod merged commit 4f73376 into matplotlib:master Aug 31, 2017
@tacaswell tacaswell deleted the doc_ipympl branch August 31, 2017 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants