Fix osx busy cursor #9157
Merged
Fix osx busy cursor #9157
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM although I can't actually test it :-) Also, does OSX actually display a busy spinner in that case? (Not that I'd consider that a blocker) |
|
Oh yeah, should have added that this fixes the issue for me! I think one other osx dev should check this before it goes in. It doesn't look like OSX is showing a spinner when I plot and move a very large scatter plot. |
|
What about fixing the problem that it returns null without an exception set? |
|
It should definitely be fixed at some point but I don't think it's release critical, considering that the issue has always been present. |
|
Fair enough. |
dopplershift
requested changes
Sep 5, 2017
src/_macosx.m
Outdated
| @@ -1902,6 +1902,7 @@ -(void)save_figure:(id)sender | |||
| case 1: [[NSCursor arrowCursor] set]; break; | |||
| case 2: [[NSCursor crosshairCursor] set]; break; | |||
| case 3: [[NSCursor openHandCursor] set]; break; | |||
| case 4: break; | |||
There was a problem hiding this comment.
Can we get a comment here about the fact that OS X handles the busy for us and doesn't provide an icon?
dopplershift
approved these changes
Sep 6, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9156. See #9156 (comment) for more information on the fix.