Skip to content

include overspilling axes legends in ax.get_tightbbox #9164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 21, 2017
Merged

include overspilling axes legends in ax.get_tightbbox #9164

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions doc/users/next_whats_new/2017-10-19_axes_legend_in_tightbbox.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
Axes legends now included in tight_bbox
---------------------------------------

Legends created via ``ax.legend()`` can sometimes overspill the limits of
the axis. Tools like ``fig.tight_layout()`` and
``fig.savefig(bbox_inches='tight')`` would clip these legends. A change
was made to include them in the ``tight`` calculations.
3 changes: 3 additions & 0 deletions lib/matplotlib/axes/_base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@
import matplotlib.image as mimage
from matplotlib.offsetbox import OffsetBox
from matplotlib.artist import allow_rasterization
from matplotlib.legend import Legend

from matplotlib.rcsetup import cycler
from matplotlib.rcsetup import validate_axisbelow
Expand Down Expand Up @@ -3969,6 +3970,8 @@ def get_tightbbox(self, renderer, call_axes_locator=True):
for child in self.get_children():
if isinstance(child, OffsetBox) and child.get_visible():
bb.append(child.get_window_extent(renderer))
elif isinstance(child, Legend) and child.get_visible():
bb.append(child._legend_box.get_window_extent(renderer))

_bbox = mtransforms.Bbox.union(
[b for b in bb if b.width != 0 or b.height != 0])
Expand Down