-
-
Notifications
You must be signed in to change notification settings - Fork 7.9k
dynamically generate pyplot functions #9173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a7131bb
to
6b8438e
Compare
6b8438e
to
3423f85
Compare
I can't understand why funcsigs isn't getting installed on appveyor+py2 :/ |
3423f85
to
f88bd65
Compare
a408d6e
to
a64c34e
Compare
6 tasks
a64c34e
to
6bf63d4
Compare
6bf63d4
to
52c68c9
Compare
475bc46
to
aed0979
Compare
aed0979
to
9ea3ce3
Compare
Replaced by #10918/#10934/... after discussion with @tacaswell. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Dynamically generate pyplot functions at import time. Functions define a proper
__signature__
(via thefuncsigs
backport on Py2, which is a new dependency).This PR does not appear to cause slowdown in the import time, as shown by
hold
functionality was removed from the pyplot functions (it is scheduled for removal anyways) to avoid a needlessly complex implementation.Remove boilerplate.py, which becomes unused.
Dynamically generate some more functions (
plt.axis
,plt.clf
, etc.) which actually fall into the same pattern. Fix their docstrings accordingly.[As a side note, some profiling suggests that right now the slowest step at import time is by far the calls to the various checkdep_* if you happen to have the
ps.usedistiller
ortext.usetex
rcparams set.]PR Checklist