Skip to content

Change axes.prop_cycle to single line in matplotlibrc.template #9189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 15, 2017

Conversation

jni
Copy link
Contributor

@jni jni commented Sep 15, 2017

Otherwise the example is invalid because the matplotlibrc parser
doesn't understand multi-line commands. See #9184.

This is a temporary fix, the true fix is to fix the parser (again, see #9184).

I thought about adding a test but couldn't figure out the best way to do so given the comment structure of the file: uncommenting all lines won't work, uncommenting the specific line of axes.prop_cycle is brittle, uncommenting only lines that start with an rcParams key will break when we do add multi-line support. Suggestions welcome, but otherwise, this can always be merged while keeping #9184 open.

  • Has Pytest style unit tests
  • Code is PEP 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

Otherwise the example is invalid because the matplotlibrc parser
doesn't understand multi-line commands. See matplotlib#9184.
@WeatherGod WeatherGod merged commit abdc2be into matplotlib:master Sep 15, 2017
@QuLogic QuLogic added this to the 2.2 (next next feature release) milestone Sep 15, 2017
tacaswell pushed a commit that referenced this pull request Sep 16, 2017
Change axes.prop_cycle to single line in matplotlibrc.template
@tacaswell
Copy link
Member

Thanks!

backported to v2.1.x as c7107cd

@QuLogic QuLogic modified the milestones: 2.2 (next next feature release), 2.1 (next point release) Sep 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants