Convert tick-setting methods to docstrings #9192
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tacaswell
reviewed
Sep 16, 2017
lib/matplotlib/axes/_base.py
Outdated
| Sequence of ticks | ||
|
|
||
| minor : bool, optional | ||
| If ``False`` sets major ticks, if ``True`` sets minor ticks. |
There was a problem hiding this comment.
I think this can also take the string 'both'.
There was a problem hiding this comment.
on second thought, that makes not much sense for this set_ method.
anntzer
reviewed
Sep 16, 2017
lib/matplotlib/axes/_base.py
Outdated
| Returns | ||
| ------- | ||
| labels : list | ||
| List of :class:`~matplotlib.text.Text` instancess |
anntzer
reviewed
Sep 16, 2017
lib/matplotlib/axes/_base.py
Outdated
| Parameters | ||
| ---------- | ||
| ticks : sequence | ||
| Sequence of ticks |
There was a problem hiding this comment.
I would just say list... and list of floats (I guess?), as it's not a list of Tick objects (unless I got this completely wrong).
There was a problem hiding this comment.
Could be a list of datetimes if it's a date axis?
There was a problem hiding this comment.
Possibly, no idea.
But "ticks" without further qualification definitely sounds like "Tick objects" to me.
35a2722 to
b4acccf
Compare
anntzer
approved these changes
Sep 19, 2017
dstansby
pushed a commit
that referenced
this pull request
Sep 19, 2017
Convert tick-setting methods to docstrings
|
Backported to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.