Set norm to log if bins=='log' in hexbin #9223
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jklymak
approved these changes
Oct 19, 2017
There was a problem hiding this comment.
This looks good.
I find the name bins for that argument very lamentable, and some of the docstring doesn't make a lick of sense to me. What does the following mean?
If an integer, divide the counts in the specified number
of bins, and color the hexagons accordingly.
If a sequence of values, the values of the lower bound of
the bins to be used.
|
Realised I could add the image test to an existing one, to avoid adding another test image. Other code is the same as before. |
|
@dstansby this needs a rebase. |
|
This also needs an API changes note. Agree it is better, but we need to document the change! |
tacaswell
approved these changes
Jul 8, 2018
Add API changes Fix hexbin test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7842. I'm pretty sure that it doesn't make sense to supply both
binsandnorm, so have warned the user if both are supplied. I may be wrong though...