Skip to content

WIP: Testing getting AppVeyor working [DO NOT MERGE] #9282

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

dopplershift
Copy link
Contributor

It seems that adding this test is when things started going sideways...

This, somehow, seems to be where things started going sideways...
@tacaswell
Copy link
Member

This makes very little sense to me...

@dopplershift
Copy link
Contributor Author

Two separate successful AppVeyor runs confirm it's related, though.

@tacaswell
Copy link
Member

Combined with the fact that adding -v to the tests seems to move the segfault to the end and that @cgohlke reports that this is dependent on a python mirco version makes me hope that this is something upstream in how BytesIO or bytes are handled.

It looks like there is a path (which we don't test?) that saves everything into memory and then embeds the frames. I think the code path we are testing is writing to a temporary directory.

@QuLogic
Copy link
Member

QuLogic commented Oct 6, 2017

It's now the third time around and still passing...

@tacaswell tacaswell added this to the 2.1.1 (next bug fix release) milestone Oct 6, 2017
@Kojoley Kojoley closed this Oct 14, 2017
@Kojoley Kojoley removed this from the 2.1.1 milestone Oct 14, 2017
@dopplershift dopplershift deleted the test-appveyor branch October 15, 2017 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants