Backport PR #9277 on branch v2.1.x #9283
Conversation
|
A downside of @meeseeksdev opening branches on the repo here is that both PRs and the branch get run through CI. This is usually fine (though suboptimal) for Travis and Circle, but really slows down AppVeyor since it doesn't run in parallel. |
|
Is there a way to convince appevyor to only run a limited set of branches? Doing the PRs from this repo is limitation of the github API (the bot can not own a repo to open the PR from). |
|
maybe the commit message for the backport just needs to include [skip ci] ? attn @Carreau |
|
I think it'd be skipped on the PR as well then. We can set exclusive branches, but just need to be careful that it doesn't also exclude the PRs too. |
|
Sorry about that, one of the limitation of using GitHub integration is they don't have their own user and can't push on a separate repo. It might be possible to hack something together by creating a fake user on GitHub, but that might be painful to maintain. I can add skip-ci, but yes that would skip the PR testing. Does appveyor have env variable that tell you which branch it's testing, if we can't completely skip, we could just abort manually if the branch name start with auto-backport-... and if the head commit is not a merge commit ? |
This should prevent the automatic backports to be tested both when the branch is pushed by the backport bot, and when the PR is opened. Hopefully the PR will be still be tested (that's unclear from the AppVeyor docs). This was discussed in matplotlib#9283 (comment) And likely need to be also applied to other CI, but Appveyor is the most annoying.
Backport PR #9277: plot_surface docstring + edge case fix