BF - Fix maximum colorbar extension. #931
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the patch. This fix already seems to be on the v1.1.x branch, but it didn't get correctly merged into master. Merging. |
mdboom
added a commit
that referenced
this pull request
Jun 7, 2012
BF - Fix maximum colorbar extension.
|
Good spot. Do you have a couple of lines of code to reproduce? I would be good to add a test for this. |
|
@pelson I was thinking something along the lines of this (but a bit more comprehensive): import numpy as np
import matplotlib.pyplot as plt
x = y = np.linspace(-np.pi, np.pi, 100)
X, Y = np.meshgrid(x, y)
Z = np.cos(Y) * np.sin(X)
levels_linear = [-.75, -.5, -.25, -0., .25, .5, .75]
fill = plt.contourf(x, y, Z, levels_linear, extend='max')
plt.colorbar(fill, orientation='horizontal')The maximum extension is blue if the bug is present, and red otherwise. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The maximum extension for colorbars was broken. This resulted in the maximum extension being the wrong color. This was introduced in commit b2f2ab9.
I traced this to a simple error when setting the number of boundaries. A check for
'min'or'both'was used instead of a check for'min'or'max'.