-
-
Notifications
You must be signed in to change notification settings - Fork 7.9k
Add Axes method for drawing infinite lines #9321
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Can you document how this interacts with semilog and loglog plots? (Even if it is "it doesn't work with them".) |
Hmm, I can't reproduce the test failure |
@anntzer I've tried this code, it seems not support any type of log scale yet. |
🎉 it works! |
what happens if we make it non-linear scale after calling |
Then you end up with a line that's incorrect in the same way as if it were set beforehand. |
Can we refactor axhline and axvline as special cases of this function? |
I also think we thanks! |
Reading axhline's and axvline's code, I see that it's not trivial (I do have to say that it's a bit annoying to have such closely related functions with slightly different APIs) |
Okay I've done a big 'ol rebase and squash, and this now uses |
Clean up axline Add axline image test Fix test image Add what's new Add note about log axes Error if trying to draw line on non-linear axes Fix scale checking Fix docstring interpolation Chnage to using xy1, xy2 Fix docs and closeness checking Raise error if points are the same Swap axline test to image comparison
I think that's all the comments taken care of, so feel free to review again. I've squashed everything into one commit, so there's no extra test image files hanging around any more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add axline to the section „Span“ in axes_api.rst.
I agree that not setting auto-limits is a good idea, but after a bit of a play around I'm not sure what the right way to do that is. Is there an easy way to exclude an |
This was discussed a while ago and there isn't really a smart way to do it; what I personally do is
(basically, save the datalimits first, add the artist, then restore the datalimits), which is a bit of a hack. |
Replaced by #15330. |
Supersedes #7506 - cleans up docstring and adds a test. Fixes #5253.