Fix poorly done deprecations in image.py. #9335
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WeatherGod
approved these changes
Oct 9, 2017
tacaswell
approved these changes
Oct 9, 2017
|
took the liberty of adding a test. |
dstansby
approved these changes
Oct 10, 2017
|
Is the appveyor failure the same as the one that has been happening? |
WeatherGod
reviewed
Oct 10, 2017
lib/matplotlib/image.py
Outdated
| @cbook.deprecated("2.1") | ||
| def _interpdr(self): | ||
| return {v: k for k, v in six.iteritems(_interpd_)} | ||
|
|
||
| @property | ||
| @cbook.deprecated("2.1") |
There was a problem hiding this comment.
Shouldn't this deprecation tell us what to use instead?
tacaswell
added a commit
that referenced
this pull request
Oct 11, 2017
Backport PR #9335 on branch v2.1.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
xref #9332.
PR Summary
PR Checklist