Skip to content

Update descriptions for images_contours_and_fields #9341

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 10, 2017
Merged

Update descriptions for images_contours_and_fields #9341

merged 1 commit into from
Oct 10, 2017

Conversation

divyam3897
Copy link
Contributor

PR Summary

Adds one line description for images_contours_and_fields
part of #8921

PR Checklist

  • Has Pytest style unit tests
  • [X ] Code is PEP 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@divyam3897 divyam3897 mentioned this pull request Oct 10, 2017
Closed
dstansby
dstansby requested changes Oct 10, 2017
View reviewed changes
Copy link
Member

@dstansby dstansby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me, just a small formatting change needed

examples/images_contours_and_fields/shading_example.py Outdated
# or Generic Mapping Tools
# (http://gmt.soest.hawaii.edu/gmt/doc/gmt/html/GMT_Docs/node145.html)


Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PEP8 requires there to be two empty lines before def main(): on the line below my comment.

@dstansby dstansby added this to the 2.1.0-docs milestone Oct 10, 2017
@divyam3897
Copy link
Contributor Author

@dstansby done 👍

dstansby
dstansby approved these changes Oct 10, 2017
View reviewed changes
Copy link
Member

@dstansby dstansby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot!

@dstansby dstansby merged commit 4ccfccb into matplotlib:master Oct 10, 2017
@choldgraf
Copy link
Contributor

TYVM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dstansby dstansby dstansby approved these changes

Assignees
No one assigned
Labels
Documentation
Projects
None yet
Milestone
v2.1.0-doc
Development

Successfully merging this pull request may close these issues.
3 participants
@divyam3897 @choldgraf @dstansby