-
-
Notifications
You must be signed in to change notification settings - Fork 7.9k
Fix edgecolor being only applied to first bar. #9353
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine to me. (I guess that ideally one might want to add some test 😈).
Actually I am thinking to add some machinery to add "as if" comparison tests, which generate two figures and checks that they are indeed identical (in this case, we would be comparing |
Well that sounds indeed cleverer that the genuine image test I was going to write... Looking quickly at |
You can already write this "by hand" (https://github.com/matplotlib/matplotlib/pull/9305/files#diff-663c17d0729218d60dbb862c286a17d4R5327), but ideally the machinery should be such that |
For this the simplest test is to pass a scalar and then just iterate over the returned artists and check the edge color is what you expect. |
fc3e07c
to
7ff9287
Compare
tests in |
Backport PR #9353 on branch v2.1.x
closes #9351
PR Summary
PR Checklist