TST: remove Python 3.5 from Appveyor [Do Not Merge] [skip travis] #9374
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kojoley
reviewed
Oct 11, 2017
| except ImportError: | ||
| pass | ||
| else: | ||
| faulthandler.enable() |
There was a problem hiding this comment.
I would remove this completely and enable it on travis with pytest-faulthandler.
There was a problem hiding this comment.
even better (optional) if you document it at http://matplotlib.org/devdocs/devel/testing.html#requirements
There was a problem hiding this comment.
- It's output is not useful if you do not have debug symbols (distutils does not produce it for windows and strips for linux by default on non-debug version)
faulthandlercould be enabled with pytest bypytest-faulthandlermodule (that's what I've suggested earlier)
There was a problem hiding this comment.
The build would pass even without disabling faulthandler.
|
We do not upload conda builds from appveyor, right? |
|
why was this closed? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #9176