Skip to content

Document get_{x,y}axis_transform more prominently. #9375

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 11, 2017

Conversation

anntzer
Copy link
Contributor

@anntzer anntzer commented Oct 11, 2017

They are quite useful but right now are documented in a slightly obscure
manner.

Closes #9369.

PR Summary

PR Checklist

  • Has Pytest style unit tests
  • Code is PEP 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

Copy link
Member

@jklymak jklymak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small typo

=========== ============================= =====================================
Coordinates Transformation object Description
=========== ============================= =====================================
"data" ``ax.transData```` The userland data coordinate system,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is a "userland"?

Copy link
Contributor Author

@anntzer anntzer Oct 11, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"from the POV of the user" but I agree it's a bit obscure. "The data coordinate system" actually sounds good enough?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

force pushed (also fixed below)

display, and (width, height) is top
right of the display in pixels.
"xaxis", ``ax.get_xaxis_transform()``, Blended coordinate systems; use data
"yaxis" ``ax.get_yaxis_transform()`` coordinates one one of the axis and
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one one -> on one

@anntzer anntzer force-pushed the doc-transforms-tutorial branch from 938cbdc to 8d8a3fc Compare October 11, 2017 22:33
They are quite useful but right now are documented in a slightly obscure
manner.
@anntzer anntzer force-pushed the doc-transforms-tutorial branch from 8d8a3fc to f19eddb Compare October 11, 2017 22:35
@jklymak jklymak merged commit de51d40 into matplotlib:master Oct 11, 2017
@jklymak
Copy link
Member

jklymak commented Oct 11, 2017

... there I went nuts and merged it. Hope that was OK - docs just require one approval, right?

@anntzer anntzer deleted the doc-transforms-tutorial branch October 11, 2017 23:42
@dstansby dstansby added this to the 2.1.0-docs milestone Oct 12, 2017
tacaswell pushed a commit that referenced this pull request Oct 12, 2017
Document get_{x,y}axis_transform more prominently.
@tacaswell
Copy link
Member

backported to v2.1.0-doc as d5a3e46

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2.1 - new problem with log ax.transData
4 participants