Skip to content

Add examples for subplots_axes_and_figures #9392

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 14, 2017
Merged

Add examples for subplots_axes_and_figures #9392

merged 1 commit into from
Oct 14, 2017

Conversation

divyam3897
Copy link
Contributor

Add descriptions for subplots_axes_and_figures
Extension to PRs for #8921

@@ -3,6 +3,7 @@
Subplots Adjust
===============

Example showing tuning of the subplots.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about "Adjusting the spacing and margins of subplots."

@@ -3,6 +3,7 @@
Subplot Toolbar
===============

Example showing various subplots which are controlled using the toolbar.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggest "Matplotlib has a toolbar available for adjusting subplot spacing"

@QuLogic
Copy link
Member

QuLogic commented Oct 13, 2017

I think both of the comments are saying that you should drop the "Example showing" part, because that's kind of redundant.

@@ -3,6 +3,7 @@
Subplots Adjust
===============

Example showing the adjusting of spacing and margins of subplots.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adjusting the spacing of margins and subplots using :func:~matplotlib.pyplot.subplots_adjust:

@@ -3,6 +3,7 @@
Subplot Toolbar
===============

Example showing toolbar of matplotlib available for adjusting subplot spacing.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Matplotlib has a toolbar available for adjusting suplot spacing.

@jklymak
Copy link
Member

jklymak commented Oct 13, 2017

@divyam3897 Thanks so much for pointing out that these descriptions were missing! I do think that your phrasing needs tweaking.

@divyam3897
Copy link
Contributor Author

@jklymak done!, let me know if it's better or requires more changes :)

@jklymak
Copy link
Member

jklymak commented Oct 14, 2017

Great! Thanks for the PR. Very helpful!

@dstansby dstansby added this to the 2.1.0-docs milestone Oct 14, 2017
Copy link
Member

@dstansby dstansby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot!

@dstansby dstansby merged commit 51640a2 into matplotlib:master Oct 14, 2017
@divyam3897 divyam3897 deleted the updateDescriptions branch October 14, 2017 18:27
@tacaswell
Copy link
Member

@meeseeksdev backport to v2.1.0-doc

tacaswell added a commit that referenced this pull request Oct 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants