Skip to content

[Doc] Add pcolor, contour, imshow to and other small changes #9394

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 14, 2017

Conversation

jklymak
Copy link
Member

@jklymak jklymak commented Oct 13, 2017

PR Summary

  • Added imshow, pcolor, and contour to ../tutorials/introductory/sample_plots.py
  • Changed command to function
  • Removed Demo from many of the titles.

Redo of #9387 (sorry @anntzer, who already commented)

PR Checklist

  • Documentation is sphinx and numpydoc compliant

Copy link
Contributor

@afvincent afvincent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A small comment after looking quickly to the PR. I know that something like

My title
===================

is valid RST, but it may be more pleasant to the eyes of most people to use

My title
========

:)

@@ -54,7 +88,7 @@

.. _screenshots_path_demo:

Path demo
Paths
=========
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree that the current version is valid RST, but would it be possible to match the length of the '====' line with the line beyond?

@@ -168,10 +202,10 @@

.. _screenshots_table_demo:

Table demo
Tables
==========
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as before, but would it be possible to match the length of the '====' line with the line beyond?

@@ -349,7 +383,7 @@

.. _screenshots_eeg_demo:

EEG demo
EEG GUI
=========
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as before: would it be possible to match the length of the '====' line with the line beyond?

======

Matplotlib can display images (assuming equal-spaced, equal-aspect-ratio
horizontal dimensions) using the :func:`~matplotlib.pyplot.imshow` function.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. you don't actually need equal aspect ratio
  2. something seems to be missing before or after "horizontal dimensions"?

@NelleV NelleV merged commit b7b7ad1 into matplotlib:master Oct 14, 2017
@NelleV
Copy link
Member

NelleV commented Oct 14, 2017

Thanks a lot @jklymak !

@tacaswell tacaswell added this to the 2.1.0-docs milestone Oct 15, 2017
@tacaswell
Copy link
Member

@meeseeksdev backport to v2.1.0-doc

lumberbot-app bot pushed a commit that referenced this pull request Oct 15, 2017
tacaswell added a commit that referenced this pull request Oct 15, 2017
@jklymak jklymak deleted the addpcolor3 branch March 5, 2019 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants