TST: Unblock Appveyor build by patching subprocess
#9395
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tacaswell
reviewed
Oct 13, 2017
.appveyor.yml
Outdated
| @@ -95,6 +95,12 @@ install: | |||
| # pytest-cov>=2.3.1 due to https://github.com/pytest-dev/pytest-cov/issues/124 | |||
| - pip install -q pytest "pytest-cov>=2.3.1" pytest-rerunfailures pytest-timeout | |||
|
|
|||
| # Apply patch to `subprocess` on Python versions > 2 and < 3.6.3 | |||
| # https://github.com/matplotlib/matplotlib/issues/9176 | |||
| - python -c "import sys; sys.exit((2,) > sys.version_info > (3,6,3))" && ( | |||
There was a problem hiding this comment.
Shouldn't this be sys.exit((3,6,3) > sys.version_info > (2,)) ?
There was a problem hiding this comment.
Yes, I wrongly negated the (2,) < sys.version_info < (3,6,3) expression.
869b84d to
6e38b4f
Compare
anntzer
reviewed
Oct 14, 2017
.appveyor.yml
Outdated
| # https://github.com/matplotlib/matplotlib/issues/9176 | ||
| - python -c "import sys; sys.exit(not (2,) < sys.version_info < (3,6,3))" && ( | ||
| curl -sL https://github.com/python/cpython/pull/1224.patch | | ||
| patch -fsup 1 -d %CONDA_PREFIX% ) || ( set errorlevel= ) |
There was a problem hiding this comment.
I thought only Py3 was affected? Both from my (possibly incorrect) remembering of what used to fail and from https://bugs.python.org/issue30121#msg300658
If it's only a py3 issue then the lower bound should be (3,); if not we can just drop the lower bound (it's not as if we will ever support py1.5 anyways :-)).
There was a problem hiding this comment.
The bug was fixed 4 years ago in Py2. Python >= 2.7.6 should not be affected.
6e38b4f to
089fe86
Compare
anntzer
approved these changes
Oct 14, 2017
dstansby
added a commit
that referenced
this pull request
Oct 14, 2017
Backport PR #9395 on branch v2.1.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #9176