Don't mark a patch transform as set if the parent transform is not set. #9426
Conversation
|
Is there a good test for this? |
|
Sorry, changed my mind about where to target this to again. |
|
To be honest, looking at it again, I am not even that certain that that the constructor of that Shadow class makes a lot of sense. Specifically, if I got it correctly, the ox and oy values are first multiplied by the dots-per-point conversion factor (e.g. 100/72 at 100dpi), then interpreted as offsets in data coordinates. Which "of course(???...)" means that the shadow can move when you save the figure (as savefig.dpi does not have to equal figure.dpi) |
|
Looking at the history this goes back to JDH in 2004 so it pre-dates the transform machinery and I would guess added as a gee-whiz feature. If you think it could be cleaned up for 2.2 👍 |
|
I'm not really convinced of the utility of providing this class, but heh. A problem with interpreting ox, oy as offsets in data units is that the only two public APIs that rely on that class (other than Shadow itself) are So perhaps ox, oy should be interpreted either as axes coordinates or figure coordinates -- don't have a clear preference right now. Edit: I think I'll let @dstansby figure out how to handle the same problem with arrows and just copy his approach :-) |
dd2cfee to
25f96fb
Compare
f99506f to
71ec6c3
Compare
|
@dstansby test has been added (a while ago, but no worries) |
71ec6c3 to
a9797a2
Compare
|
@dstansby Would you like to re-review and merge if it is OK? |
When updating a patch from another artist, if the other artist's transform is marked as "uninitialized" (`_transformSet == False`), then don't mark the updatee's transform as set either. Typically, this occurs if the updator has not been added to an Axes yet; its transform will be set when that adding occurs. In that case, the updatee's transform also needs to be set when actually being added to an Axes.
a9797a2 to
f4d158d
Compare
|
Seems ready to go in for 3.0 so labeling as RC. |
When updating a patch from another artist, if the other artist's
transform is marked as "uninitialized" (
_transformSet == False), thendon't mark the updatee's transform as set either.
Typically, this occurs if the updator has not been added to an Axes yet;
its transform will be set when that adding occurs. In that case, the
updatee's transform also needs to be set when actually being added to an
Axes.
Closes the incorrect transform part of #9377.
PR Summary
PR Checklist