Fix instance of 'RendererPS' has no 'tex' member #9448
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@cgohlke How did you discover this problem? |
|
For my recent PRs, I was scanning pylint errors and warnings for potential issues. I do not have a regression test. Given how old this code is and no one noticed (?), maybe this code can be removed? |
anntzer
approved these changes
Nov 28, 2017
|
Thanks @cgohlke ! |
|
@meeseeksdev backport to v2.1.x |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
RendererPS.texfunction does not appear to be defined anywhere. I assume this is thedraw_texfunction? Not sure since this code is around for so many years. Am I missing something?