Skip to content

FIX: Always update tick labels (fixes #9397) #9452

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 17, 2017

Conversation

afvincent
Copy link
Contributor

@afvincent afvincent commented Oct 17, 2017

PR Summary

Force the update of all the tick labels, even the ones that are not drawn. This addresses the issue #9397 where incorrect labels are returned when some ticks are outside of the displayed range. Please note that the fix idea is @anntzer's one.

PR Checklist

  • Has Pytest style unit tests
  • [?] Code is PEP 8 compliant => Well let's CI confirm ^^
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • [?] Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way => @tacaswell Should I add an entry?

Milestoning it for 2.1.1 as it looks like a minor bugfix to me but feel free to postpone it to 2.2 if somebody thinks that it would be better. (see edit)

Supplementary question: should I rebase against the 2.1.x branch?

Edit: re-milestoning it for v2.2, accordingly to what @dstansby suggested in #9397.

@afvincent afvincent added this to the v2.1.1 milestone Oct 17, 2017
@afvincent afvincent modified the milestones: v2.1.1, v2.2 Oct 17, 2017
Copy link
Contributor

@anntzer anntzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess that'll count as @afvincent's approval of my patch... :-)

@afvincent afvincent force-pushed the fix_incorrect_labels_issue_9397 branch from 45eb1ae to 27fd53a Compare October 17, 2017 03:48
@afvincent
Copy link
Contributor Author

Rebased to fix some PEP8 issues...

@NelleV NelleV merged commit 4937314 into matplotlib:master Oct 17, 2017
@QuLogic QuLogic modified the milestones: needs sorting, v2.2.0 Feb 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants