Skip to content

Changes to better highlight development-workflow in docs #9473

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 19, 2017

Conversation

jklymak
Copy link
Member

@jklymak jklymak commented Oct 18, 2017

PR Summary

The full instructions to use github are at :ref:development-workflow, but this is not linked in
dev/Contributing except in a seealso::

The link in the PR template was there but was just in reference to whether I should create out of a separate branch or not. Of course the link is much more informative than that.

PR Checklist

  • Code is PEP 8 compliant
  • Documentation is sphinx and numpydoc compliant

@jklymak
Copy link
Member Author

jklymak commented Oct 18, 2017

I killed AppVeyor and Travis as this code doesn't need tests.

@NelleV
Copy link
Member

NelleV commented Oct 19, 2017

FYI, I don't think that adding any information to the pull request template is useful. People just don't read those.

@NelleV NelleV merged commit 1a50874 into matplotlib:master Oct 19, 2017
@jklymak
Copy link
Member Author

jklymak commented Oct 19, 2017

@NelleV ...and it’s often too late at that point ;-)

@QuLogic QuLogic added this to the v2.2 milestone Oct 20, 2017
@QuLogic QuLogic modified the milestones: needs sorting, v2.2.0 Feb 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants