Added description to widget example programs except Cursor and Menu #9478
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
divyam3897
suggested changes
Oct 19, 2017
examples/widgets/buttons.py
Outdated
| @@ -2,7 +2,7 @@ | |||
| ======= | |||
| Buttons | |||
| ======= | |||
|
|
|||
| An pretty cool example to show how to use buttons widget.The program shows a simple GUI with a sine wave changing its frequency.The next and previous button widget used here helps shows the wave with new frequency. | |||
There was a problem hiding this comment.
An pretty cool? You should not have had the first line, a small description should be there. Don't use the words like "an example to show etc"
There was a problem hiding this comment.
Sorry it was 'A' . And yes will remove the first line.
examples/widgets/slider_demo1.py
Outdated
| =========== | ||
| Slider Demo | ||
| =========== | ||
|
|
There was a problem hiding this comment.
There is no description added, why changes in the whole file?
There was a problem hiding this comment.
Sorry about that. I think I din't save the changes. I will fix it.
|
Fixed it. Could you please check. |
|
Hi @ash13 |
3d55690 to
cf356ac
Compare
|
Thanks @ash13 and @choldgraf ! |
tacaswell
added a commit
that referenced
this pull request
Oct 21, 2017
Backport PR #9478 on branch v2.1.0-doc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Was working on #8921 to add one line description for the example programs: I worked on the example programs related to widgets. I was not able to check the Curosr and the menu widget. Other than those widgets, I have added description to the rest. Please do review and let me know if it needs any changes.
examples/widgets/buttons.py - Done
examples/widgets/check_buttons.py - Done
examples/widgets/cursor.py - Had few errors in my system. Will work on it. Not done.
examples/widgets/lasso_selector_demo_sgskip.py - Done
examples/widgets/menu.py - Din't work on my system. Will work on it.
examples/widgets/multicursor.py - Done
examples/widgets/radio_buttons.py - Done
examples/widgets/slider_demo.py- Done
examples/widgets/textbox.py - Done
LINK: #8921
PR Checklist