-
-
Notifications
You must be signed in to change notification settings - Fork 7.9k
adding links to color examples and tutorials in the api page #9544
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm +1 on colorblind-friendly cmap documentation, though wanna keep the scope of this PR relatively narrow since I don't have a ton of time to iterate on this :-) if you give me text that is guaranteed to get approved quickly then I'll add it to this PR, else let's leave it for another PR...that work? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the link doesn't work (and causes linkchecker to fail). see https://github.com/matplotlib/matplotlib/pull/9532/files#diff-577656b3176ed2aa2443bf660405d7b6R11 for the correct syntax.
@anntzer thanks for the check...latest push uses |
Ah yes (but as a general rule & side note, there's a bunch of
which could advantageously be replaced by :doc: |
I definitely don't think to do that often enough - I agree that's a better way to do it looks like the links work now: |
@anntzer 's wording is ""for an in-depth overview of colomaps, including discussion about colorblind-friendliness, see (tutorial)". |
ah I see - I thought you meant to actually add in a discussion of colorblind friendliness in this page. I'm happy to add this in, though TBH we have a pretty scarce treatment of color blindness in the tutorial. E.g. this is the only section I see: http://matplotlib.org/tutorials/colors/colormaps.html#color-vision-deficiencies I would be a big +1 on a doc addition that added a more complete treatment for (and list of) colorblind-friendly colormaps. |
Thanks @choldgraf |
@choldgraf totally agree with you that it should probably be a doc addition and would also be +1 for a more complete treatment and list of colorblind friendly maps and pallets (for line/scatter/etc type plots). |
per @anntzer 's suggestion, this adds links on the colors API page to the gallery and tutorial section.