Fixed logformatting for non integer bases. #960
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -567,9 +567,8 @@ class LogFormatter(Formatter): | |||
| """ | |||
| Format values for log axis; | |||
|
|
|||
| if attribute *decadeOnly* is True, only the decades will be labelled. | |||
There was a problem hiding this comment.
This is not true:
$> grep -ir decadeOnly *
Binary file doc/build/doctrees/api/ticker_api.doctree matches
doc/build/html/api/ticker_api.html:<p>if attribute <em>decadeOnly</em> is True, only the decades will be labelled.</p>
lib/matplotlib/ticker.py: if attribute *decadeOnly* is True, only the decades will be labelled.
lib/matplotlib/ticker.py: self.decadeOnly = True
|
This is a small-ish change if anyone is prepared to go over it? |
|
I don't like how you do the string formatting of the 'b' variable separately from the formatting of the rest of the label. Why not do the string concatenation of the needed format string for the base and then do all the formatting at once? |
|
I agree that it is a little awkward to follow. I'm not seeing your suggestion though, do you mean make |
|
Yes. Do all the string formatting at once. |
|
Ok @WeatherGod, I think this resolves your concern. |
|
Looks good to me. Feel free to merge. |
|
Right, thanks for that. Merging... |
WeatherGod
added a commit
that referenced
this pull request
Aug 3, 2012
Fixed logformatting for non integer bases.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #909.