Skip to content

Added an entry for mpl-scatter-density in the third-party tools page #9614

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 31, 2017
Merged

Added an entry for mpl-scatter-density in the third-party tools page #9614

merged 1 commit into from
Oct 31, 2017

Conversation

astrofrog
Copy link
Contributor

@anntzer
Copy link
Contributor

anntzer commented Oct 29, 2017

I was trying to keep the packages in alphabetical order (and yes that means that Decida should be moved up too). Can you fix that? Otherwise lgtm.

@astrofrog
Copy link
Contributor Author

@anntzer - done! I think the Travis failure was unrelated btw.

@tacaswell tacaswell added this to the v2.1.0-doc milestone Oct 29, 2017
tacaswell
tacaswell approved these changes Oct 29, 2017
View reviewed changes
Copy link
Member

@tacaswell tacaswell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pending circle passing.

@tacaswell
Copy link
Member

pandas 0.21 broke one of our tests.

@anntzer
Copy link
Contributor

anntzer commented Oct 30, 2017

@astrofrog do you mind if I push a (losslessly) pngcrush'ed version of the image? that chops off half of the image size, from 300K to 150K... (useful not only for not bloating the history but also for viewing the docs over slow connections...)
(would also squash merge to remove the previous image from the history)

@astrofrog
Copy link
Contributor Author

@anntzer - please feel free to do this!

@anntzer
Copy link
Contributor

anntzer commented Oct 30, 2017

@astrofrog I'll let you squash out the old png from the history (and check that the new one suits you -- they should be exactly identical).

@astrofrog astrofrog force-pushed the add-mpl-scatter-density branch from 04580f9 to 0b943e7 Compare October 31, 2017 21:19
@astrofrog
Copy link
Contributor Author

astrofrog commented Oct 31, 2017 •
edited
Loading

@anntzer - done, thanks!

dstansby
dstansby approved these changes Oct 31, 2017
View reviewed changes
Copy link
Member

@dstansby dstansby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Anyone can feel free to merge when tests pass!

@anntzer anntzer merged commit 7f8e63a into matplotlib:master Oct 31, 2017
@anntzer
Copy link
Contributor

anntzer commented Oct 31, 2017

Thanks!

lumberbot-app bot pushed a commit that referenced this pull request Oct 31, 2017
@anntzer
Backport PR #9614: Added an entry for mpl-scatter-density in the thir…
afe9e62 
…d-party tools page
@lumberbot-app lumberbot-app bot mentioned this pull request Oct 31, 2017
Merged
anntzer added a commit that referenced this pull request Nov 1, 2017
@anntzer
Merge pull request #9647 from matplotlib/auto-backport-of-pr-9614
7cb8f0c 
Backport PR #9614 on branch v2.1.0-doc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tacaswell tacaswell tacaswell approved these changes

@dstansby dstansby dstansby approved these changes

Assignees
No one assigned
Labels
Documentation
Projects
None yet
Milestone
v2.1.0-doc
Development

Successfully merging this pull request may close these issues.
4 participants
@astrofrog @anntzer @tacaswell @dstansby