Do not hardcode fill=False in mark_inset #9615
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There should not be any reason to hardcode fill=False in `mark_inset`. This prevents having a filled Bbox_Patch. With the proposed change, something like `mark_inset(ax,axins,loc1=1,loc2=3, fill=True, edgecolor="k", facecolor="lightgrey")` will again be possible (it was in v1.3 but got broken at some point).
tacaswell
approved these changes
Oct 29, 2017
|
Thanks @ImportanceOfBeingErnest The travis failure is the pandas 0.21 issue. |
QuLogic
approved these changes
Oct 29, 2017
|
Thanks @ImportanceOfBeingErnest ! Hopefully we will hear from you again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There should not be any reason to hardcode
fill=Falseinmark_inset. This prevents having a filledBboxPatch. With the proposed change, something likemark_inset(ax,axins,loc1=1,loc2=3, fill=True, edgecolor="k", facecolor="lightgrey")will be possible and would look like
(See this stackoverflow question)
PR Summary
PR Checklist